Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Toggle password visible" button works the other way round. #2772

Closed
2 of 5 tasks
alinadivante opened this issue Apr 23, 2019 · 1 comment
Closed
2 of 5 tasks

"Toggle password visible" button works the other way round. #2772

alinadivante opened this issue Apr 23, 2019 · 1 comment
Labels
1: Easy bug Bug reports QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Apr 23, 2019

Current behavior

When user wants make his password visible he has to press on "eye" icon instead "eye-slash"
image

Expected behavior

I expect the reverse behavior, as with other applications (like Gmail has).
image

Steps to reproduce the issue

  1. Go to https://test.storefrontcloud.io
  2. Press My account button
  3. Type some text in Password filed
  4. Press "Toggle password visibility" icon

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added bug Bug reports feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can and removed bug Bug reports labels Apr 23, 2019
@pkarw pkarw added 1: Easy vs-hackathon Tasks for the Hackathon labels Apr 23, 2019
@lukeromanowicz lukeromanowicz added bug Bug reports and removed feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can labels Apr 23, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Apr 23, 2019
lukeromanowicz added a commit to lukeromanowicz/vue-storefront that referenced this issue Apr 23, 2019
@pkarw pkarw modified the milestones: 1.10.0-rc.1, 1.9.0 Apr 23, 2019
pkarw added a commit that referenced this issue Apr 23, 2019
@pkarw pkarw closed this as completed Apr 23, 2019
@alinadivante alinadivante added the QA approved on branch Testers will add this label after positive check on specific branch. label Apr 24, 2019
@alinadivante
Copy link
Collaborator Author

verified locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

3 participants