-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email address is needed to give a feedback #2814
Comments
I will add this |
we need to just get the e-mail address from the checkout form and add it to the message body |
So just add use email to the feedback? Where? Before the content? How it'll resolve the error of checkoutPersonalEmailAddress when the user is a guest? |
@ZeevGerstner it’s up to you; no strong preferences. We do have the email as this page is visible only after order has been placed |
You are right but still we getting that error that Source email address is not provided. |
[vue-storefront-hackathon] I will tackle this one now. |
It seems, the problem is the server itself. The request is correctly send to the server:
But the response is:
|
@alinadivante it's another error, the one above has been fixed in #3265. Apparently the one from #2814 has been fixed by someone else. |
ok, so I'm waiting for my |
checked on https://test.storefrontcloud.io/ environment - Email has successfully been sent 👌 |
@alinadivante @pkarw shouldn't it be closed? |
Thx |
What is the motivation for adding / enhancing this feature?
When user is not logged in then he can't give a feedback, because his email is not charged from the checkout.
![image](https://user-images.githubusercontent.com/36628922/56803996-92a66300-6824-11e9-8aeb-efc8b23cc23a.png)
What are the acceptance criteria
We need create special field for email address or address must be taken from the checkout.
Can you complete this feature request by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Additional information
The text was updated successfully, but these errors were encountered: