Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address is needed to give a feedback #2814

Closed
2 of 6 tasks
alinadivante opened this issue Apr 26, 2019 · 13 comments
Closed
2 of 6 tasks

Email address is needed to give a feedback #2814

alinadivante opened this issue Apr 26, 2019 · 13 comments
Assignees
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Apr 26, 2019

What is the motivation for adding / enhancing this feature?

When user is not logged in then he can't give a feedback, because his email is not charged from the checkout.
image

What are the acceptance criteria

We need create special field for email address or address must be taken from the checkout.

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@alinadivante alinadivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Apr 26, 2019
@pkarw pkarw added 1: Easy vs-hackathon Tasks for the Hackathon labels Apr 26, 2019
@ZeevGerstner
Copy link
Contributor

I will add this

@pkarw
Copy link
Collaborator

pkarw commented May 1, 2019

we need to just get the e-mail address from the checkout form and add it to the message body

@ZeevGerstner
Copy link
Contributor

So just add use email to the feedback? Where? Before the content? How it'll resolve the error of checkoutPersonalEmailAddress when the user is a guest?
Think Im missing something...

@pkarw
Copy link
Collaborator

pkarw commented May 2, 2019

@ZeevGerstner it’s up to you; no strong preferences. We do have the email as this page is visible only after order has been placed

@ZeevGerstner
Copy link
Contributor

You are right but still we getting that error that Source email address is not provided.
That's what should happen?
Any way all you want is that i'll add in the emailText the user mail? if so do you want to show it to the user or just add it to his feedback?

@mbarten
Copy link

mbarten commented May 24, 2019

[vue-storefront-hackathon] I will tackle this one now.

@mbarten
Copy link

mbarten commented May 24, 2019

It seems, the problem is the server itself.

The request is correctly send to the server:

emailText: "qsdasd"
sourceAddress: "asdasd@everycademy.de"
subject: "What we can improve?"
targetAddress: "contributors@vuestorefront.io"
token: "eyJ0..."

But the response is:

code: 500
result: "Invalid email address is provided!"

@alinadivante
Copy link
Collaborator Author

Hey, there is still no way to send feedback.
please see my screenshot
image

@alinadivante alinadivante reopened this Jul 22, 2019
@alinadivante alinadivante added the QA rejected Testers will add this label when something is still wrong label Jul 22, 2019
@Michal-Dziedzinski
Copy link
Collaborator

Michal-Dziedzinski commented Jul 22, 2019

@alinadivante it's another error, the one above has been fixed in #3265. Apparently the one from #2814 has been fixed by someone else.

@alinadivante
Copy link
Collaborator Author

ok, so I'm waiting for my Ready for QA label 😄

@alinadivante
Copy link
Collaborator Author

checked on https://test.storefrontcloud.io/ environment - Email has successfully been sent 👌

@alinadivante alinadivante removed the QA rejected Testers will add this label when something is still wrong label Aug 20, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@Michal-Dziedzinski
Copy link
Collaborator

@alinadivante @pkarw shouldn't it be closed?

@pkarw pkarw closed this as completed Jan 21, 2020
Issue Kanban automation moved this from Accepted Feature Requests to Done Jan 21, 2020
@pkarw
Copy link
Collaborator

pkarw commented Jan 21, 2020

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon
Projects
No open projects
Issue Kanban
  
Done
Development

No branches or pull requests

6 participants