Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mail sending and add error logger #3265

Merged
merged 5 commits into from
Jul 23, 2019

Conversation

Michal-Dziedzinski
Copy link
Collaborator

@Michal-Dziedzinski Michal-Dziedzinski commented Jul 22, 2019

Short description and why it's useful

Fix mail sending and added error logger

Screenshots of visual changes before/after (if there are any)

Before changes:
Zrzut ekranu (17)

After changes:
Zrzut ekranu (18)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace .then/.catch with async/await

core/modules/mailer/store/index.ts Show resolved Hide resolved
@pkarw
Copy link
Collaborator

pkarw commented Jul 23, 2019

Thanks for the changes ;)

@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 23, 2019
@patzick patzick added this to In progress in StorefrontUI based theme for VS 1.11 via automation Jul 23, 2019
@patzick patzick merged commit 8b828e0 into vuestorefront:develop Jul 23, 2019
StorefrontUI based theme for VS 1.11 automation moved this from In progress to Done Jul 23, 2019
@alinadivante
Copy link
Collaborator

alinadivante commented Aug 20, 2019

checked on https://test.storefrontcloud.io/ environment - Email has successfully been sent 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants