-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remake order functionality non-deterministic behavior #2964
Comments
…inistic cart sync behaviors + refactor to async/await #2964
Ok, it’s on the branch 2513 right? |
Yes @pkarw - feature/2513 |
OK, I've refactored it a little bit #2887 |
Nice job! |
@pkarw I tested it again, after merging, but now I see a problem with a duplicate notification and it takes a while before the user is redirected to the checkout. See my new video. Imho there should be loader displayed or information about the processing. |
OK, we need to add the check for duplicated notification in the |
I've also got a console error: vuex.esm.js:410 [vuex] unknown action type: cart/getPaymentMethods |
Check also the |
Plus as @alinadivante wrote - adding a popup / blocking loader |
Current behavior
Remake order functionality ends up with random number of products in cart if not locked on backend side. Probably due to the asynchronicity of the requests.
Expected behavior
Remake order functionality should end up with the same number of products in cart after clicking remake order.
Steps to reproduce the issue
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.The text was updated successfully, but these errors were encountered: