Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations for multistore - it_IT / de_DE #3076

Closed
5 tasks
alinadivante opened this issue Jun 19, 2019 · 6 comments
Closed
5 tasks

Missing translations for multistore - it_IT / de_DE #3076

alinadivante opened this issue Jun 19, 2019 · 6 comments
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront P4: Nice to have Priority mark - it's nice to have vs-hackathon Tasks for the Hackathon

Comments

@alinadivante
Copy link
Collaborator

Current behavior

  1. Order confirmation page - lack of translations
  2. Product page:
  • Color Black
  • Size XS
  • Reviews section
  • We found other products you might like section
  1. Pop-ups:
  • "Something went wrong. Try again in a few seconds."
  • This product is out of stock.
  • "PROCEED TO CHECKOUT"
  • "Processing order"
  • "We don't have as many "Minerva LumaTech™ V-Tee-S-Black" as you requested."
  1. Cart:
  • Subtotal
  • Shipping & Handling (Flat Rate - Fixed)
  • Tax
  • Grand Total
  • Color: Black
  • Size: S
  • In stock!
  • Clear cart
  • Discount
  1. Checkout
  • Subtotal
  • Shipping & Handling (Flat Rate - Fixed)
  • Tax
  • Grand Total
  1. My account:
  • Homepage / My Account
  • My Recently viewed products
  1. Wishlist
  • Clear wishlist
  1. Compare Products
  • Homepage / Compare
  1. Categories:
  • sub-categories names
  • Clear filters
  • Columns
  • Sort by: Latest, Price low to high, high to low,
  • X items
  • "Please change Your search criteria and try again. If still not finding anything relevant, please visit the Home page and try out some of our bestsellers!"
  1. Breadcrumbs
  • Homepage / Magazine
  • Homepage / Contact
  • Homepage / Size guide
  • etc
  1. Search:
  • Filter by categories
  • Load more button
  1. Error page:
  • Something went wrong ...

Expected behavior

All translations should be in accordance with the language of the store.

Steps to reproduce the issue

  1. Change your config:
  • "multistore": false, → true
  • "appendStoreCode": true, → false
  • "disabled": true. → false
  1. Go to http://localhost:3000/it/ or http://localhost:3000/de

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Jun 19, 2019
@pkarw pkarw changed the title Missing translations for multistore Missing translations for multistore - it_IT / de_DE Jun 19, 2019
@pkarw pkarw added the P4: Nice to have Priority mark - it's nice to have label Jun 19, 2019
@pkarw pkarw added the good first issue Tasks that requires just basic understanding of Vue Storefront label Jul 6, 2019
@pkarw pkarw added the vs-hackathon Tasks for the Hackathon label Jul 25, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 12, 2019

@ResuBaka / @nhp can you please help us with this issue? :) It's not anything challenging but well, if you know german it's 15min max and ticket closed :) would be awesome

@lorenaramonda may I ask you for help with italian one's? :)

@lorenaramonda
Copy link
Collaborator

Sure @pkarw if you can wait till Monday because I’m on vacation now with no computer 😶

@pkarw
Copy link
Collaborator

pkarw commented Sep 12, 2019

Sure thing @lorenaramonda; have a great holidays!

@lorenaramonda
Copy link
Collaborator

I fixed a typo on default language as a separate PR -> #3596

lorenaramonda added a commit to lorenaramonda/vue-storefront that referenced this issue Sep 21, 2019
lorenaramonda added a commit to lorenaramonda/vue-storefront that referenced this issue Sep 21, 2019
@lorenaramonda
Copy link
Collaborator

I guess that trings like We don't have as many "Minerva LumaTech™ V-Tee-S-Black" as you requested." are coming directly from Magento/Api so they should come already translated because on the frontend we don't have a placeholder for the product name in that string so it is not possible to localize it.

patzick added a commit that referenced this issue Sep 21, 2019
patzick added a commit that referenced this issue Sep 21, 2019
ref. #3076 fix typo on a string and related translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront P4: Nice to have Priority mark - it's nice to have vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

5 participants
@pkarw @lorenaramonda @andrzejewsky @alinadivante and others