Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image proxy url work with relative base url #3158

Closed
2 of 5 tasks
cewald opened this issue Jun 29, 2019 · 1 comment
Closed
2 of 5 tasks

Make image proxy url work with relative base url #3158

cewald opened this issue Jun 29, 2019 · 1 comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority
Milestone

Comments

@cewald
Copy link
Contributor

cewald commented Jun 29, 2019

Current behavior

If you use a relative images.baseUrl like /img/ the path won't be build using the api.url config value like in the other endpoint, which forces you to use an absolute url at this point again.

Expected behavior

Make image proxy url work with a relative base url using the processURLAddress() method.

Steps to reproduce the issue

You can see it with each visible product image.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: all
  • OS: all
  • Node: default
  • Code Version: Known in master and develop

Additional information

Nope

@cewald cewald added the bug Bug reports label Jun 29, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 29, 2019

Good point! Thanks!

@pkarw pkarw added P3: Normal Priority mark - normal priority 3: Medium complexity labels Jun 29, 2019
@pkarw pkarw added this to the 1.10.0 milestone Jun 29, 2019
pkarw added a commit that referenced this issue Jun 29, 2019
Make image proxy url work with relative base url (#3158)
@pkarw pkarw closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

2 participants