Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image proxy url work with relative base url (#3158) #3159

Merged

Conversation

cewald
Copy link
Contributor

@cewald cewald commented Jun 29, 2019

Related issues

closes #3158

Short description and why it's useful

You won't need another absolute url in configs.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw pkarw added this to the 1.11.0-rc.1 milestone Jun 29, 2019
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that missing puzzle!

@pkarw pkarw changed the base branch from develop to release/v1.10 June 29, 2019 11:58
@pkarw pkarw changed the base branch from release/v1.10 to develop June 29, 2019 11:58
@pkarw pkarw merged commit 71c851a into vuestorefront:develop Jun 29, 2019
@cewald cewald deleted the bugfix/3158-relative-img-proxy-url branch June 30, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants