Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move multistore from store to core lib #2241

Conversation

lukeromanowicz
Copy link
Contributor

@lukeromanowicz lukeromanowicz commented Jan 18, 2019

Related issues

#2224 based on #2225 to avoid conflicts

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@lukeromanowicz lukeromanowicz changed the title Refactor/move multistore from store to core lib Move multistore from store to core lib Jan 18, 2019
import Request from '../types/search/Request'
import Response from '../types/search/Response'

export interface HttpQuery {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of this as we discussed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filrak done

@filrak filrak merged commit 2cb89e0 into vuestorefront:develop Jan 21, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants