Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2226 Move store/types to core/types and use named exports #2246

Merged
merged 7 commits into from
Jan 18, 2019

Conversation

kruchy8
Copy link
Collaborator

@kruchy8 kruchy8 commented Jan 18, 2019

Related issues

#2226

Short description and why it’s useful

Changing location of type files,
hackathon 4

Screenshots of visual changes before/after (if there are any)

no changes

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

Before:
image

After:
image

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I’ve updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@filrak filrak merged commit 8151657 into vuestorefront:develop Jan 18, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants