Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move store/types to core/types and use named exports #2226

Closed
filrak opened this issue Jan 17, 2019 · 7 comments
Closed

Move store/types to core/types and use named exports #2226

filrak opened this issue Jan 17, 2019 · 7 comments
Assignees
@kruchy8
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Milestone
1.8

Comments

@filrak
Copy link
Collaborator

filrak commented Jan 17, 2019

What is the motivation for adding / enhancing this feature?

In the process of getting rid of content from core/store types should moved and merged with core/types folder. We should also use named export instead of default one to have consistant naming across whole application

What are the acceptance criteria

  • Types from core/store/types are moved to core/types
  • Types with default export are using named export now
  • all import pathes are corrected
@filrak filrak added good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon labels Jan 17, 2019
@kruchy8
Copy link
Collaborator

kruchy8 commented Jan 18, 2019

I'll try it

kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Changelog
4604f75
@lukeromanowicz
Copy link
Contributor

lukeromanowicz commented Jan 18, 2019 •
edited
Loading

@kruchy8 please ignore core/store/types/search as they were merged to core/store/search in #2225

kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move RootState types file to core/types & imports …
dbcd861 
…update
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Response types file to core/types & imports u…
94a6055 
…pdate
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Task types file to core/types & import update
43d2aad
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Request types file to core/types & imports up…
a80dbb0 
…date
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move HttpQuery types file to core/types & imports …
21db60b 
…update
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move isomorphic-fetch types file to core/types
a02b543
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Changelog
80717eb
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move RootState types file to core/types & imports …
7b52e0f 
…update
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Response types file to core/types & imports u…
20b7f52 
…pdate
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Task types file to core/types & import update
fd5e59c
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move Request types file to core/types & imports up…
0e86fa3 
…date
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move HttpQuery types file to core/types & imports …
5652cf0 
…update
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Move isomorphic-fetch types file to core/types
67f169d
kruchy8 added a commit to kruchy8/vue-storefront that referenced this issue Jan 18, 2019
@kruchy8
vuestorefront#2226 Changelog
719ed41
@kruchy8 kruchy8 mentioned this issue Jan 18, 2019
Merged
5 tasks
@kruchy8
Copy link
Collaborator

kruchy8 commented Jan 18, 2019 •
edited
Loading

@lukeromanowicz I have already moved it into another folder, do you want me to revert this changes?
@filrak please include my account into collaborators

@lukeromanowicz
Copy link
Contributor

@kruchy8 well... the conflict is certain, the question is who's gonna resolve it :)

@kruchy8
Copy link
Collaborator

kruchy8 commented Jan 18, 2019

I'm leaving it up to you guys

@lukeromanowicz
Copy link
Contributor

@kruchy8 let's leave your version of code, I'll fix mine

@kruchy8
Copy link
Collaborator

kruchy8 commented Jan 18, 2019

👍

filrak added a commit that referenced this issue Jan 18, 2019
@filrak
Merge pull request #2246 from kruchy8/feature/2226
8151657 
#2226 Move store/types to core/types and use named exports
@filrak filrak closed this as completed Jan 21, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kruchy8 kruchy8

Labels
good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
4 participants
@pkarw @kruchy8 @filrak @lukeromanowicz