Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2940 #3043

Merged
merged 5 commits into from
Jun 12, 2019
Merged

Bugfix/2940 #3043

merged 5 commits into from
Jun 12, 2019

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Jun 11, 2019

Related issues

closes #2940

Short description and why it's useful

I've simplified the condition - currently there was an logick-error in which when the final_price < regular_price the special_price got zeroed. Which makes totally no sense :)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

I've simplified the condition - currently there was an logick-error in which when the final_price < regular_price the special_price got zeroed. Which makes totally no sense :)
@pkarw pkarw changed the base branch from master to develop June 11, 2019 10:39
@pkarw pkarw requested a review from patzick June 11, 2019 10:39
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Jun 11, 2019
@pkarw pkarw modified the milestone: 1.10.0-rc.1 Jun 11, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 11, 2019
@patzick patzick merged commit b50704f into develop Jun 12, 2019
@patzick patzick removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 12, 2019
@patzick patzick deleted the bugfix/2940 branch June 12, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants