Next: useUiNotification

[lukaszjedrasik]

Related Issues

closes #5363

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (if There Are Any)

Nagranie.z.ekranu.2021-01-8.o.14.42.06.mp4

Nagranie.z.ekranu.2021-01-8.o.14.46.57.mp4

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

• Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
• RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
• Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)
• I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE

• Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[coveralls]

Pull Request Test Coverage Report for Build 469251453

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.8%) to 95.553%

---

Totals
Change from base Build 469148148:	0.8%
Covered Lines:	704
Relevant Lines:	730

---

💛 - Coveralls

[github-actions]

💙 vsf-next-demo successfully deployed at https://b3613b123406e55fadc9f4beca2b23c69f06c524.vsf-next-demo.preview.storefrontcloud.io

[lukaszjedrasik]

@filrak

I have removed the remove function from public API and I decided to add id to the UiNotification interface.
Based on id we can remove a proper notification from the array. What do you think?

[lukaszjedrasik]

Just like we talked about, I have removed remove function and added dismiss in each notification.

[Fifciu]

I wonder...
Shouldn't we put here [...state.notifications]?
Currently, computed returns reference to the Heap. So probably it is still possible to modify an array via methods like push etc.

Wdyt @andrzejewsky @filrak ?

[filrak]

lets leave it like this