Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing mobile menu to ct #6184

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Aug 12, 2021

Short Description of the PR

Added missing mobile menu to CT

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I tested manually my code and it works well with both:
  • Default Theme
  • Capybara Theme
  • I have written test cases for my code

@github-actions github-actions bot added commercetools Next Issues/bugs for Vue Storefront Next labels Aug 12, 2021
@github-actions github-actions bot added the docs Tasks regarding documentation label Aug 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021

💙 vsf-next-demo successfully deployed at

const isMobile = computed(() => mapMobileObserver().isMobile.get());

onMounted(() => {
isMobile.value = mapMobileObserver().isMobile.get();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hwo about SSR here?

@github-actions github-actions bot added the core label Aug 12, 2021
@andrzejewsky andrzejewsky merged commit 3e00e74 into next Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commercetools core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants