IN-4062 Consolidate engineering-toolkit #7107
Conversation
eslint + prettier config packages
documentation update and fixes
updated eslint config file
fixed eslint rules for vue
fix: unlocked TypeScript class methods overloading
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* rebranding * rebranding * rebranding * update readmes --------- Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io> Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: f3e2549 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7305177 | Triggered | Basic Auth String | e8e4cbf | engineering-toolkit/github-actions/check-licenses/dist/index.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| @@ -0,0 +1,12 @@ | |||
| This folder contains GitHub Actions commonly used in some of our repositories. | |||
There was a problem hiding this comment.
This is a new file that points people to the packages/* directory in case they mistakenly open the engineering-toolkit or the actions/* folder instead of going to packages/*
https://github.com/mozilla/eslint-plugin-no-unsanitized/blob/main/package.json#L36 We normally use GitGuardian for this a a pre-commit hook, so this eslint plugin is redundant
|
GitGuardian is complaining about an example comment |
Move packages from vuestorefront/engineering-toolkit to this repo as part of the repo consolidation initative.