Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint to versions that support TS 5.4 #7161

Merged
merged 1 commit into from
May 22, 2024

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented May 21, 2024

In this PR I'm doing it only for the integrations eslint package.

Prevent warnings during linting such as below, when running TypeScript 5.4.5:

@vsf-enterprise/bloomreach-discovery-sdk:lint: $ eslint . --ext .ts,.js
@vsf-enterprise/bloomreach-discovery-sdk:lint: =============
@vsf-enterprise/bloomreach-discovery-sdk:lint: 
@vsf-enterprise/bloomreach-discovery-sdk:lint: WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
@vsf-enterprise/bloomreach-discovery-sdk:lint: 
@vsf-enterprise/bloomreach-discovery-sdk:lint: You may find that it works just fine, or you may not.
@vsf-enterprise/bloomreach-discovery-sdk:lint: 
@vsf-enterprise/bloomreach-discovery-sdk:lint: SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0
@vsf-enterprise/bloomreach-discovery-sdk:lint: 
@vsf-enterprise/bloomreach-discovery-sdk:lint: YOUR TYPESCRIPT VERSION: 5.4.5
@vsf-enterprise/bloomreach-discovery-sdk:lint: 

@sethidden sethidden requested a review from a team as a code owner May 21, 2024 11:33
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 611c0aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/eslint-config-integrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -23,8 +23,8 @@
"access": "public"
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.59.9",
"@typescript-eslint/parser": "^5.59.9",
"@typescript-eslint/eslint-plugin": "^7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves the version range to something that we still support (TS 4.7) so I'd say so

@sethidden sethidden merged commit 087f29c into main May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants