fix(overlayable): avoid overlay generation toggle if not active

fixes #8142
vuetifyjs · Oct 15, 2019 · 4c61674 · 4c61674
1 parent 2165628
commit 4c61674
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/packages/vuetify/src/mixins/overlayable/__tests__/overlayable.spec.ts b/packages/vuetify/src/mixins/overlayable/__tests__/overlayable.spec.ts
@@ -71,4 +71,26 @@ describe('Overlayable.ts', () => {
 
     expect(wrapper.vm.overlay.zIndex).toBe(8)
   })
+
+  // https://github.com/vuetifyjs/vuetify/issues/8142
+  it('should not update overlay state if not active', () => {
+    const cb = jest.fn()
+    const wrapper = mountFunction({
+      methods: {
+        removeOverlay: cb,
+        genOVerlay: cb,
+      },
+    })
+
+    wrapper.setProps({ hideOverlay: true })
+    wrapper.setProps({ hideOverlay: false })
+
+    expect(cb).not.toHaveBeenCalled()
+
+    wrapper.setData({ isActive: true })
+    wrapper.setProps({ hideOverlay: true })
+    wrapper.setProps({ hideOverlay: false })
+
+    expect(cb).toHaveBeenCalledTimes(1)
+  })
 })
diff --git a/packages/vuetify/src/mixins/overlayable/index.ts b/packages/vuetify/src/mixins/overlayable/index.ts
@@ -46,6 +46,8 @@ export default Vue.extend<Vue & Toggleable & Stackable & options>().extend({
 
   watch: {
     hideOverlay (value) {
+      if (!this.isActive) return
+
       if (value) this.removeOverlay()
       else this.genOverlay()
     },