Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow setting origin of dialog's zoom animation to activator's location #1068

Closed
lephuongbg opened this issue Jul 20, 2017 · 0 comments
Closed

[Feature Request] Allow setting origin of dialog's zoom animation to activator's location #1068

lephuongbg opened this issue Jul 20, 2017 · 0 comments
Assignees
@KaelWD
Labels
C: VDialog VDialog T: feature A new feature
Projects
Vuetify 3 - Titan
Milestone
v3.0.0

Comments

@lephuongbg
Copy link
Contributor

lephuongbg commented Jul 20, 2017 •
edited

What will it allow you to do that you can't do today?

It would be nice if there is a setting to make it that when a dialog appears, it will be perceived like it is originating from the activating button. Current implementation only allows animation from screen edge or screen center.

An implementation can be seen with Angular Material:
https://material.angularjs.org/latest/demo/dialog

This would help the dialog to align with Surface Creation spec:
https://material.io/guidelines/motion/choreography.html#choreography-creation

How will it make current work-arounds straightforward?

Not sure if there is any work-around to do that.

What potential bugs and edge cases does it help to avoid?

Just an improvement to UX IMHO.
@nekosaur nekosaur added T: feature A new feature pending review The issue is still pending disposition labels Jul 20, 2017
@johnleider johnleider removed the pending review The issue is still pending disposition label Jul 23, 2017
@nekosaur nekosaur added this to the v1.1.x milestone Oct 21, 2017
@vuetifyjs vuetifyjs deleted a comment from michaelmarconi Jan 31, 2018
@vuetifyjs vuetifyjs deleted a comment from amritk Jan 31, 2018
@vuetifyjs vuetifyjs deleted a comment from zhanghuanchong Jan 31, 2018
@johnleider johnleider removed this from the v1.1.x milestone Feb 9, 2018
@johnleider johnleider added this to the v1.2.x milestone Apr 30, 2018
@KaelWD KaelWD modified the milestones: v1.2.0, v1.4.0 Jul 31, 2018
@KaelWD KaelWD modified the milestones: v1.4.0, v1.5.0 Nov 24, 2018
@MajesticPotatoe MajesticPotatoe changed the title Feature Request: Allow setting origin of dialog's zoom animation to activator's location [Feature Request] Allow setting origin of dialog's zoom animation to activator's location Dec 7, 2018
@jacekkarczmarczyk jacekkarczmarczyk removed this from the v1.5.0 milestone Feb 10, 2019
@blalan05 blalan05 added the C: VDialog VDialog label Apr 9, 2019
@KaelWD KaelWD mentioned this issue Apr 21, 2020
Open
@johnleider johnleider added this to To do in Vuetify 3 - Titan via automation Nov 30, 2020
@KaelWD KaelWD self-assigned this May 20, 2021
@KaelWD KaelWD added this to the v3.0.0 milestone May 20, 2021
@KaelWD KaelWD mentioned this issue May 20, 2021
Merged
KaelWD added a commit that referenced this issue May 26, 2021
@KaelWD
feat: create v-dialog and v-overlay components (#13681)
f06f5b4 
Closes #1068
Closes #4807 (class now applies to the root teleported element)
Fixes #6425
Closes #6764
Fixes #7422
Closes #8105
Closes #9595
Fixes #9632
Fixes #11263
@KaelWD KaelWD closed this as completed May 26, 2021
Vuetify 3 - Titan automation moved this from To do to Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VDialog VDialog T: feature A new feature
Projects
No open projects
Vuetify 3 - Titan
Done
Milestone
v3.0.0
Development

No branches or pull requests
7 participants
@nekosaur @lephuongbg @peluprvi @johnleider @jacekkarczmarczyk @KaelWD @blalan05