Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hide main scrollbar when dialog is open #8105

Closed
TheInvoker opened this issue Jul 27, 2019 · 8 comments
Closed

[Feature Request] Hide main scrollbar when dialog is open #8105

TheInvoker opened this issue Jul 27, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@TheInvoker
Copy link

Environment

Vuetify Version: 2.0.1
Vue Version: 2.6.10
Browsers: Chrome 69.0.3497.100
OS: Windows 10

Steps to reproduce

Click the pink button to open dialog.

Expected Behavior

The main page which has a scroll bar, should hide when the dialog is open. This is because you shouldn't be able to scroll on the main page anyways, and it gives a little extra room horizontally (or vertically) for the dialog. Plus since the dialog is almost full width, it looks bad to see 2 scroll bars next to each other.

Actual Behavior

The main scroll bar still appears when dialog is open.

Reproduction Link

https://codepen.io/anon/pen/VomBbd

Other comments

Can it be changed to hide the main page scrollbars (up/down/left/right) while dialog is open?

@ghost ghost added the S: triage label Jul 27, 2019
@diazemiliano-zz diazemiliano-zz added C: VDialog VDialog T: question A question that does not match a bug or feature request labels Aug 1, 2019
@diazemiliano-zz
Copy link

diazemiliano-zz commented Aug 1, 2019

@TheInvoker Not sure if this is a bug. And for sure is something that you can control based on the v-model state of the dialog or using events to listen when the dialog is opened to set the overflow: hidden where you need it.

@TheInvoker
Copy link
Author

I had my own solution for this, but if this is a popular thing to do, might as well come by default from the framework?

@diazemiliano-zz diazemiliano-zz added help wanted We are looking for community help and removed S: triage labels Aug 1, 2019
@Dylan-Chapman

This comment has been minimized.

@johnleider johnleider self-assigned this Sep 9, 2019
@johnleider johnleider added P: sponsor and removed help wanted We are looking for community help T: question A question that does not match a bug or feature request labels Sep 9, 2019
@Traxo7

This comment has been minimized.

@TheInvoker

This comment has been minimized.

@Traxo7

This comment has been minimized.

@TheInvoker

This comment has been minimized.

@johnleider johnleider added this to the v2.1.x milestone Dec 3, 2019
@johnleider johnleider modified the milestones: v2.1.x, v2.2.x Dec 18, 2019
@KaelWD KaelWD added the T: feature A new feature label Jan 10, 2020
@KaelWD KaelWD removed this from the v2.2.x milestone Jan 10, 2020
@KaelWD
Copy link
Member

KaelWD commented Jan 10, 2020

It was done to prevent a layout jump afaik. See #10086 for the other thing.

@KaelWD KaelWD changed the title [Bug Report] Main page scroll doesn't hide when dialog is open [Feature Request] Hide main scrollbar when dialog is open Jan 10, 2020
@KaelWD KaelWD assigned KaelWD and unassigned johnleider May 20, 2021
@KaelWD KaelWD added this to the v3.0.0 milestone May 20, 2021
KaelWD added a commit that referenced this issue May 26, 2021
Closes #1068
Closes #4807 (class now applies to the root teleported element)
Fixes #6425
Closes #6764
Fixes #7422
Closes #8105
Closes #9595
Fixes #9632
Fixes #11263
@KaelWD KaelWD closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants