Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.0.0-beta.9] v-select with chips props is not proper spacing #15686

Closed
alokVishu opened this issue Aug 25, 2022 · 0 comments · Fixed by #17175
Closed

[Bug Report][3.0.0-beta.9] v-select with chips props is not proper spacing #15686

alokVishu opened this issue Aug 25, 2022 · 0 comments · Fixed by #17175
Labels
S: triage

Comments

@alokVishu
Copy link
Contributor

Environment

Vuetify Version: 3.0.0-beta.9
Vue Version: 3.2.37
Browsers: Chrome 104.0.0.0
OS: Windows 10

Steps to reproduce

Try to use compact and comfortable density with chips props.

Expected Behavior

It should maintain proper spacing in compact and comfortable density.

Actual Behavior

The chips touch the bottom line of v-select.

Reproduction Link

https://codepen.io/Alokdev/pen/LYdopgq?editors=101
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Sep 9, 2022
@patrickclerc
fix(VSelect): correct chips spacing for compact and comfortable density
b93c812 
fixes vuetifyjs#15686
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Sep 10, 2022
@patrickclerc
fix(VSelect): correct chips spacing for compact and comfortable density
7010a29 
fixes vuetifyjs#15686
@patrickclerc patrickclerc mentioned this issue Sep 10, 2022
Merged
8 tasks
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Sep 26, 2022
@patrickclerc
fix(VSelect): correct chips spacing for compact and comfortable density
f66d088 
fixes vuetifyjs#15686
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Oct 5, 2022
@patrickclerc
fix(VSelect): address review comments
9fdca51 
Use integer for density intervals in sass
fixes vuetifyjs#15686
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Oct 5, 2022
@patrickclerc
fix(VFileInput): correct chips spacing
921c3c7 
Add top and bottom margins for chips when used with compact or
comfortable density.
fixes vuetifyjs#15686
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Oct 5, 2022
@patrickclerc
fix(VAutocomplete): correct chips spacing
b92a69b 
Add top and bottom margins for chips when used with compact or
comfortable density.
fixes vuetifyjs#15686
patrickclerc added a commit to patrickclerc/vuetify that referenced this issue Oct 5, 2022
@patrickclerc
fix(VCombobox): correct chips spacing
a69815f 
Add top and bottom margins for chips when used with compact or
comfortable density.
fixes vuetifyjs#15686
johnleider added a commit that referenced this issue Oct 13, 2022
@patrickclerc @nekosaur @johnleider
fix(VSelect): correct chips spacing for compact and comfortable (#15770)
073eca7 
fixes #15686

Co-authored-by: nekosaur <albert@kaaman.nu>
Co-authored-by: John Leider <john@vuetifyjs.com>
yuwu9145 added a commit that referenced this issue Apr 29, 2023
@yuwu9145
keep fixing issue #15686
023079d
@yuwu9145 yuwu9145 mentioned this issue Apr 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VField): match chips line-height, center prepend/append vuetifyjs/vuetify
1 participant
@alokVishu