Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog does not open in Edge #2146

Closed
sullivanpt opened this issue Oct 11, 2017 · 3 comments
Closed

Dialog does not open in Edge #2146

sullivanpt opened this issue Oct 11, 2017 · 3 comments
Assignees
@johnleider
Labels
P: critical The issue is of critical importance T: bug Functionality that does not work as intended/expected

Comments

@sullivanpt
Copy link

Steps to reproduce

Versions

Vuetify 0.16, Windows 10, build 1703, Edge 40.15063.674.0

What is expected ?

dialog should render
(in my memory this feature worked on edge in the previous release)

What is actually happening ?

nothing visible changes.
If console is open the message is "Object doesn't support property or method 'Symbol(Symbol.iterator)'"

Reproduction Link

https://vuetifyjs.com/components/dialogs
@johnleider johnleider added T: bug Functionality that does not work as intended/expected P: critical The issue is of critical importance labels Oct 11, 2017
@johnleider johnleider self-assigned this Oct 11, 2017
@mi1971
Copy link

mi1971 commented Oct 11, 2017 •
edited
Loading

Hey guys.....Actually, John this is the exact same bug I've been talking to you about with iOS. Might be actually easier to trace what is going on with edge browser. Here is my video about it. https://youtu.be/I_Ghdsu6aLk (dialogs work in 0.16.1 and fail in 0.16.5

johnleider added a commit that referenced this issue Oct 12, 2017
@johnleider
fix($browser): Edge bug with for..of
55c1a44 
The new z-index functionality utilizes for..of quite extensively. When a HTMLElementList is iterated
on using for..of and the list is empty, causes Edge to throw a Symbol.iterator fatal

fixes #2146
@johnleider johnleider mentioned this issue Oct 12, 2017
Merged
@KaelWD KaelWD mentioned this issue Oct 12, 2017
Closed
@KaelWD
Copy link
Member

KaelWD commented Oct 12, 2017

Looks like edge doesn't support iterating over HtmlCollections. Here's a codepen that fixes it by installing babel-polyfill: https://codepen.io/anon/pen/NaBvzO?editors=1011

#2150 Will fix this without a polyfill by converting the HtmlCollection to an array first.

johnleider added a commit that referenced this issue Oct 12, 2017
@johnleider
Fix/2146 (#2150)
7419706 
* fix($browser): iPhone iOS click-outside bug

iOS does not allow click events to be bound to the body, this is the entire purpose of v-app. Was
mistakenly allowed to be removed with PR #1932

* fix($browser): Edge bug with for..of

The new z-index functionality utilizes for..of quite extensively. When a HTMLElementList is iterated
on using for..of and the list is empty, causes Edge to throw a Symbol.iterator fatal

fixes #2146

* refactor: Change forEach to an iterator & update comments to be clearer

Converting the NodeList to an array is enough to fix the issue, but this
wasn't reflected in the comments

* Update click-outside.js
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
P: critical The issue is of critical importance T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sullivanpt @mi1971 @johnleider @KaelWD