Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] v-img does not work in v-flex with certain v-layout props #5757

Closed
ekreutzer opened this issue Nov 28, 2018 · 1 comment
Closed
Assignees
Labels
C: VImg VImg T: enhancement Functionality that enhances existing features
Milestone

Comments

@ekreutzer
Copy link

ekreutzer commented Nov 28, 2018

Versions and Environment

Vuetify: 1.3.10
Vue: 2.5.17
Browsers: Chrome 70.0.3538.110
OS: Windows 10

Steps to reproduce

Have v-layout align-center justify-center column, with flex's inside, and a v-img inside the flex. As can be seen in the codepen, the v-img only works if there is text or another component/element contained within the flex. The red border is around the flex in which the lone v-img should be appearing.

Expected Behavior

The images should always work, obviously. It should not matter whether there are other elements in the component or flex.

Actual Behavior

The image only appears if there is another component within the flex.

Reproduction Link

https://codepen.io/tkted/live/BGqJEK

@KaelWD KaelWD added the T: enhancement Functionality that enhances existing features label Nov 29, 2018
@KaelWD KaelWD self-assigned this Nov 29, 2018
@KaelWD
Copy link
Member

KaelWD commented Nov 29, 2018

v-img has no actual content, therefore relies on the parent to provide width. I can fix this pretty easily, but I'm not sure if it should be the new default, with the current behaviour behind a prop; or keep the current default and add a prop for this.

Current behaviour, image width determined by parent:
image

New behaviour, image expands to its native size, limited by available space:
image

KaelWD added a commit that referenced this issue Nov 29, 2018
johnleider pushed a commit that referenced this issue Dec 2, 2018
@KaelWD KaelWD reopened this Jan 2, 2019
@KaelWD KaelWD added this to the v2.0.0 milestone Apr 13, 2019
dsseng pushed a commit that referenced this issue Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VImg VImg T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

4 participants