Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] autoSelectFirst on v-combobox doesn't work #6607

Closed
lephuongbg opened this issue Feb 26, 2019 · 3 comments
Closed

[Bug Report] autoSelectFirst on v-combobox doesn't work #6607

lephuongbg opened this issue Feb 26, 2019 · 3 comments
Assignees
Labels
C: VCombobox VCombobox
Milestone

Comments

@lephuongbg
Copy link
Contributor

Versions and Environment

Vuetify: 1.5.2
Vue: 2.6.7
Browsers: Chrome 72.0.3626.119
OS: Linux x86_64

Steps to reproduce

  1. Set autoSelectFirst to true on v-combox component
  2. Typing in keyword

Expected Behavior

First row should be selected

Actual Behavior

First row is not selected

Reproduction Link

https://jsfiddle.net/185fmdh2/

Other comments

autoSelectFirst is implemented in VAutocomplete by onFilteredItemsChanged () method, while in VCombobox this function is overriden to be empty. I don't know why it should be empty (no comment explaining the decision in the code) so I won't be able to make a pull request. Hopefully this will be fix soon.

@MajesticPotatoe MajesticPotatoe added the C: VCombobox VCombobox label Apr 9, 2019
@douglasg14b
Copy link

Also seeing this.

Spent way too long trying to figure out if I was doing something wrong, turns out it just doesn't work.

@mcsantos7
Copy link

I'm having the same issue here. The behavior just doesn't match the docs and, as @lephuongbg said, the method that should handler this is overwritten with no explanation...

@johnleider
Copy link
Member

This was caused by us ignoring onFilteredItemsChange which handled this selection. The reason was so the user could enter loosely close items and not trigger, but that doesn't make much sense as the functionality would only occur if that prop was explicitly used, in which case you know what you're signing up for. This will go out with v2.0.

@johnleider johnleider modified the milestones: v2.0.x, v2.0.0 Jul 2, 2019
@johnleider johnleider self-assigned this Jul 2, 2019
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCombobox VCombobox
Projects
None yet
Development

No branches or pull requests

5 participants