Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VInput): attrs should be applied on input not root element #7579

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

nekosaur
Copy link
Member

Description

this fixes issue where setting for example tabindex on checkbox
results in it being applied both in input element and on root div

Motivation and Context

closes #5412

How Has This Been Tested?

Markup:

<template>
  <v-layout row>
    <v-checkbox tabindex="0" label="asd"></v-checkbox>
  </v-layout>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

this fixes issue where setting for example tabindex on checkbox
results in it being applied both in input element and on root div

closes #5412
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #7579 into next will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7579      +/-   ##
==========================================
- Coverage   86.94%   86.93%   -0.02%     
==========================================
  Files         326      326              
  Lines        8540     8540              
  Branches     2154     2154              
==========================================
- Hits         7425     7424       -1     
- Misses       1025     1026       +1     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/components/VInput/VInput.ts 97.18% <ø> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 93.04% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e494a...d6ca775. Read the comment docs.

@nekosaur nekosaur merged commit 318553a into next Jun 21, 2019
@nekosaur nekosaur deleted the fix/checkbox-tabindex branch June 21, 2019 18:09
@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants