Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): only show focus if activated by keyboard #14059

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Aug 15, 2021

Resolves #3923
Resolves #8572
Resolves #9808

Only works in browsers that support :focus-visible, webkit just shows the normal focus overlay (including on click 馃槧). It is possible to polyfill this but idk how that behaves with @supports

Markup:

<template>
  <v-app>
    <v-container>
      <v-btn variant="text" color="primary">Button</v-btn>
      <v-btn variant="contained-text" color="primary">Button</v-btn>
      <div class="my-5" />
      <v-btn color="primary">Button</v-btn>
    </v-container>
  </v-app>
</template>
Peek.2021-08-16.00-11.mp4

@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: VBtn VBtn labels Aug 15, 2021
@KaelWD KaelWD added this to the v3.0.0 milestone Aug 15, 2021
@KaelWD KaelWD self-assigned this Aug 15, 2021
@KaelWD KaelWD requested a review from a team August 15, 2021 14:29
@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Aug 16, 2021
@KaelWD KaelWD merged commit addbd2f into next Aug 17, 2021
Vuetify 3 - Titan automation moved this from In progress to Done Aug 17, 2021
@KaelWD KaelWD deleted the fix/focus-visible branch August 17, 2021 10:14
@kingyue737
Copy link
Contributor

Will this fix be merged into version2 ?

@KaelWD
Copy link
Member Author

KaelWD commented Oct 22, 2021

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtn VBtn T: enhancement Functionality that enhances existing features
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants