Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Focus / Outline Indicator for Buttons #3923

Closed
dmcknight26 opened this issue Apr 24, 2018 · 3 comments
Closed

[Feature Request] Focus / Outline Indicator for Buttons #3923

dmcknight26 opened this issue Apr 24, 2018 · 3 comments
Assignees
Labels
C: VBtn VBtn T: enhancement Functionality that enhances existing features T: feature A new feature
Milestone

Comments

@dmcknight26
Copy link

Problem to solve

Currently when tabbing through a group of buttons it can be extremely difficult (if not impossible) to tell which one is currently focused. Especially for normal and icon buttons that have a color applied to them. Generally browsers will apply a blue outline around the focused element to indicate to the user that is the currently focused element.

Proposed solution

Support (or re-enable) the default blue outline that's applied to focused elements, perhaps making that a configuration option for the element. Failing that Google Play Music has an interesting take on icon buttons which applies an outer grayish circle on focused icon buttons that have a color assigned to them. You can see an example here which shows the pause button currently being focused: https://imgur.com/a/nCTJdsc. This could be a nice alternative...

@nekosaur nekosaur added the pending review The issue is still pending disposition label May 4, 2018
@KaelWD KaelWD removed the pending review The issue is still pending disposition label Jun 18, 2018
@johnleider johnleider added T: enhancement Functionality that enhances existing features T: feature A new feature labels Sep 14, 2018
@johnleider johnleider added this to the v2.0.0 milestone Sep 14, 2018
@blalan05 blalan05 added the C: VBtn VBtn label Apr 9, 2019
@johnleider
Copy link
Member

Going to move this to help wanted as we have met MD2 spec for v2 and this did not make the cut.

@johnleider johnleider added the help wanted We are looking for community help label Jun 19, 2019
@johnleider johnleider removed this from the v2.0.0 milestone Jun 19, 2019
@renoirb
Copy link

renoirb commented Nov 11, 2020

For reference, here is the WCAG success criterion this issue is about.

For the issue regarding button focus visibility

It's WCAG 2.4.7, w3.org/WAI/WCAG21/quickref, some more notes are in w3.org/WAI/WCAG21/Understanding section

The bigger the visible change the easier it is for someone to see, authors are encouraged to make the change as large as possible. For example, a thick outline around the element.

The bigger the visible change the easier it is for someone to see

@johnleider johnleider added this to the v3.0.0 milestone Nov 19, 2020
@johnleider johnleider removed the help wanted We are looking for community help label Nov 19, 2020
@johnleider johnleider added this to To do in Vuetify 3 - Titan via automation Nov 30, 2020
@KaelWD
Copy link
Member

KaelWD commented Feb 17, 2021

My current implementation uses a more opaque overlay on buttons with dark backgrounds:

image
image

This is still only 1.45 contrast against unfocused buttons, but you can customise it per colour with --v-theme-<color>-overlay-multiplier (here it's 4):
image

Another solution would be a lighter ring overlaid only on keyboard focus like material-ui:
image

One problem is if it's too opaque it can make the text unreadable.

@KaelWD KaelWD self-assigned this Feb 17, 2021
KaelWD added a commit that referenced this issue Aug 17, 2021
@KaelWD KaelWD closed this as completed Aug 17, 2021
Vuetify 3 - Titan automation moved this from To do to Done Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtn VBtn T: enhancement Functionality that enhances existing features T: feature A new feature
Projects
No open projects
Development

No branches or pull requests

6 participants