Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Ripples): fix typo #7181

Closed
wants to merge 3 commits into from
Closed

docs(Ripples): fix typo #7181

wants to merge 3 commits into from

Conversation

suyi91
Copy link

@suyi91 suyi91 commented May 11, 2019

Description

fix typo in Chinese for Ripples

Motivation and Context

How Has This Been Tested?

none

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to master, rebase to next.

@suyi91 suyi91 changed the base branch from master to next May 12, 2019 10:51
@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #7181 into next will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7181      +/-   ##
==========================================
- Coverage   85.77%   85.43%   -0.34%     
==========================================
  Files         333      298      -35     
  Lines        8644     7221    -1423     
  Branches     2174     1804     -370     
==========================================
- Hits         7414     6169    -1245     
+ Misses       1138      956     -182     
- Partials       92       96       +4
Impacted Files Coverage Δ
...onents/VCalendar/mixins/calendar-with-intervals.ts 6.25% <0%> (-93.75%) ⬇️
...s/vuetify/src/components/VCalendar/mixins/mouse.ts 8% <0%> (-92%) ⬇️
...s/vuetify/src/components/VCalendar/mixins/times.ts 12% <0%> (-88%) ⬇️
...vuetify/src/components/VCalendar/VCalendarDaily.ts 8.47% <0%> (-77.97%) ⬇️
...uetify/src/components/VCalendar/VCalendarWeekly.ts 8.92% <0%> (-75%) ⬇️
...y/src/components/VCalendar/mixins/calendar-base.ts 29.62% <0%> (-70.38%) ⬇️
...ges/vuetify/src/components/VCalendar/util/props.ts 40% <0%> (-60%) ⬇️
...etify/src/components/VCalendar/VCalendarMonthly.ts 57.14% <0%> (-42.86%) ⬇️
...y/src/components/VTreeview/util/filterTreeItems.ts 68.75% <0%> (-31.25%) ⬇️
...ages/vuetify/src/components/VCalendar/VCalendar.ts 7.44% <0%> (-30.86%) ⬇️
... and 377 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30d072...4bef05a. Read the comment docs.

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #7181 into next will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7181      +/-   ##
==========================================
- Coverage   85.77%   85.75%   -0.02%     
==========================================
  Files         333      333              
  Lines        8644     8644              
  Branches     2174     2174              
==========================================
- Hits         7414     7413       -1     
- Misses       1138     1139       +1     
  Partials       92       92
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.ts 93.99% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30d072...1adc811. Read the comment docs.

@vercel vercel bot temporarily deployed to staging May 12, 2019 10:51 Inactive
@suyi91 suyi91 closed this May 12, 2019
@suyi91 suyi91 mentioned this pull request May 12, 2019
8 tasks
@jacekkarczmarczyk
Copy link
Member

Also #7182 (comment)

@lock lock bot locked as resolved and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants