Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy docs with a docker container #7929

Merged
merged 3 commits into from
Jul 23, 2019
Merged

chore: deploy docs with a docker container #7929

merged 3 commits into from
Jul 23, 2019

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Jul 23, 2019

This reverts commit 1e28f5a.

Zeit claims to support node 10.15, but only installs up to 10.7

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #7929 into next will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7929      +/-   ##
==========================================
+ Coverage   85.64%   85.65%   +0.01%     
==========================================
  Files         333      333              
  Lines        9091     9091              
  Branches     2414     2414              
==========================================
+ Hits         7786     7787       +1     
+ Misses       1212     1211       -1     
  Partials       93       93
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.ts 94.13% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674b03f...6df4e2f. Read the comment docs.

@KaelWD KaelWD changed the title chore: deploy docs with node 12.5 chore: deploy docs with a docker container Jul 23, 2019
@KaelWD KaelWD merged commit a264ec0 into next Jul 23, 2019
@KaelWD KaelWD deleted the chore/zeit-node-12 branch July 23, 2019 09:37
@DRoet
Copy link
Contributor

DRoet commented Jul 23, 2019

Idk how well Zeit uses the docker cache, but usually its better to first copy over the package.json / .lock file and install the dependencies and then copy over the rest of the source files, instead of a wildcard copy.

something like:

FROM mhart/alpine-node:12

COPY package.json yarn.lock ./

RUN yarn
RUN yarn build

COPY . .

EXPOSE 8095

CMD ["yarn", "start"]

This way it won't have to install all the dependencies if it is just the source files that are changing.

@KaelWD
Copy link
Member Author

KaelWD commented Jul 23, 2019

ah k, it wasn't any slower than the default node deploy so I didn't bother seeing if it could be improved.

This would only work for the initial yarn install stage though, and would require a bit of maintenance to make sure all the packages and postinstall hooks are copied correctly what with the whole monorepo thing

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants