Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make document of updateDOM configurable #7

Merged
merged 1 commit into from Jan 19, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 19, 2021

I am working on migrating this into vite-ssg where I need to merge the existing head with the rendered one. This PR make updateDOM decoupled from the global variable and easier to provide a custom mock to receive the updates (jsdom in my case)

@egoist egoist merged commit b48809a into main Jan 19, 2021
@egoist egoist deleted the feat/configurable-document branch January 19, 2021 11:34
@egoist
Copy link
Collaborator

egoist commented Jan 19, 2021

@shipjs prepare I hope you're fixed this time 😅

@github-actions
Copy link
Contributor

@egoist shipjs prepare done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants