fix: improved deduping for charset, base, link, etc
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you help resolving the conflicts? Thanks |
antfu
approved these changes
Sep 16, 2022
…/improved-deduping
|
Thanks for the review @antfu! Conflict is resolved in this PR |
|
🤣 conflicts again :P |
…/improved-deduping
|
Hm I think because I merged this branch into the other one, thinking that you'd merge this one first :P So I'll close this because the code is in main now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #64, #32
The solution is to modify the dedupe key function to provide more explicit instructions on how the tag should be deduped.