Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useTitle should restore the title on beforeUnmount/unmount #3568

Closed
4 tasks done
segevfiner opened this issue Nov 19, 2023 · 0 comments · Fixed by #3570
Closed
4 tasks done

useTitle should restore the title on beforeUnmount/unmount #3568

segevfiner opened this issue Nov 19, 2023 · 0 comments · Fixed by #3570
Labels
enhancement New feature or request

Comments

@segevfiner
Copy link

Clear and concise description of the problem

If you navigate away from a component that used useTitle, the title it has set will remain, which makes this composable not very useful as is as a means of dynamically setting the title like you could do with @vueuse/head or unhead.

Suggested solution

useTitle should restore the title on onBeforeUnmount or similar.

Alternative

Not using it.

Additional context

No response

Validations

@segevfiner segevfiner added the enhancement New feature or request label Nov 19, 2023
Doctor-wu added a commit to Doctor-wu/vueuse that referenced this issue Nov 19, 2023
- can pass stopOnUnmounted to stop watchers when the component unmount

fix vueuse#3568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant