Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useElementVisibility): directive support #1377

Merged
merged 12 commits into from
Mar 15, 2022
Merged

feat(useElementVisibility): directive support #1377

merged 12 commits into from
Mar 15, 2022

Conversation

AllenYu0118
Copy link
Contributor

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu requested a review from webfansplz March 9, 2022 06:55
@AllenYu0118 AllenYu0118 marked this pull request as draft March 10, 2022 10:48
@AllenYu0118 AllenYu0118 marked this pull request as ready for review March 13, 2022 14:25
@antfu antfu requested a review from webfansplz March 14, 2022 01:02
@antfu antfu merged commit de14228 into vueuse:main Mar 15, 2022
@AllenYu0118 AllenYu0118 deleted the feat-useElementVisibility branch March 20, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AllenYu0118 @webfansplz @antfu