Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(useTextSelection): fix layout issues in the demo #1857

Merged
merged 2 commits into from
Jul 12, 2022
Merged

docs(useTextSelection): fix layout issues in the demo #1857

merged 2 commits into from
Jul 12, 2022

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Jul 11, 2022

This PR aims to improve the usetextselection's demo by addressing its layout issues.

Additional context

Currently when the user selects something on the page, the "Selected rects" section of the demo overflows:

image

also, the "Selected text" label is far away from the text that it describes:

image

After this PR:

image

Let me know what you think about these changes


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 494f11c into vueuse:main Jul 12, 2022
sibbng pushed a commit to sibbng/vueuse that referenced this pull request Jul 13, 2022
yjl9903 pushed a commit to yjl9903/vueuse that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants