Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix function link #1907

Merged
merged 3 commits into from
Jul 14, 2022
Merged

docs: fix function link #1907

merged 3 commits into from
Jul 14, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jul 14, 2022

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Jul 14, 2022

Well this is intentional. As not all the functions are laying under /core/. We have set the redirection on netlify. If it's broken I think we probably need target="_blank" or add logic for handle the redirection in client side SPA.

@sibbng
Copy link
Member Author

sibbng commented Jul 14, 2022

add logic for handle the redirection in client side SPA

I looked at vitepress' router code but it seems there is no way to bypass client side routing without adding target="_blank". So, I just added target="_blank" and fixed useScreenSafeArea link.

@sibbng sibbng requested a review from antfu July 14, 2022 08:35
@antfu antfu merged commit 40c794f into vueuse:main Jul 14, 2022
@sibbng sibbng deleted the docs/fix-functions-link branch July 14, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants