Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useContextMenu): new function #2151

Closed
wants to merge 21 commits into from

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Aug 31, 2022

Description

Add custom contextMenu to an Element.

this PR depends on 2 changes:

demo.mov

Additional context

I closed the previous PR because the commit history is too messy.
And of course feel free to correct my English grammar issues in the files~ 🤪


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

vaakian and others added 3 commits August 31, 2022 19:10
* feat(useContextMenu): new function

* fix(useMouseInElement): use `MaybeComputedElementRef`

* feat(useElementSize): support  `box` sizing

* feat(useWindowSize): support `includeScrollbar` option
Copy link

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to close the previous pr. If it is closed, you need to review it again. Can you do some unit testing on this feature and fix the previous review. #2136

@vaakian
Copy link
Contributor Author

vaakian commented Sep 1, 2022

You don't have to close the previous pr. If it is closed, you need to review it again. Can you do some unit testing on this feature and fix the previous review. #2136

An unit testing file is included in the latest commit. but t's quite verbose in some way(:

@wheatjs
Copy link
Member

wheatjs commented Sep 1, 2022

I think any changes to other composables(e.g. useMouseInElement) should be done in separate PRs

@vaakian
Copy link
Contributor Author

vaakian commented Sep 1, 2022

I think any changes to other composables(e.g. useMouseInElement) should be done in separate PRs

I thought the same, but this PR needs those changes to make the new function work, so I must wait until those separate PRs are merged before opening this PR, otherwise the CI would fail.

Sorry about my terrible git skill, is there a decent workaround to do this?

@wheatjs
Copy link
Member

wheatjs commented Sep 1, 2022

It would be best to open up the other PRs and just make a note of it in this one that it depends on the other PRs. Once those are merged you can then bring this on up to date with main and then the tests will pass

@vaakian
Copy link
Contributor Author

vaakian commented Sep 1, 2022

Thanks, sounds nice. I will do this later.

@vaakian vaakian closed this Sep 3, 2022
@vaakian vaakian reopened this Sep 3, 2022
@vaakian vaakian requested a review from wheatjs September 3, 2022 11:00
@stale
Copy link

stale bot commented Nov 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 6, 2022
@antfu antfu added no stale and removed stale labels Nov 7, 2022
@vaakian vaakian closed this Nov 14, 2022
@vaakian vaakian reopened this Dec 18, 2022
@antfu antfu removed the no stale label Feb 19, 2023
@stale
Copy link

stale bot commented Jun 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2023
@stale stale bot closed this Jun 20, 2023
@YunYouJun
Copy link
Contributor

There seems to be no other PRs, is it time for it to move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants