New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useContextMenu): new function #2151
Conversation
* feat(useContextMenu): new function * fix(useMouseInElement): use `MaybeComputedElementRef` * feat(useElementSize): support `box` sizing * feat(useWindowSize): support `includeScrollbar` option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to close the previous pr. If it is closed, you need to review it again. Can you do some unit testing on this feature and fix the previous review. #2136
An unit testing file is included in the latest commit. but t's quite verbose in some way(: |
I think any changes to other composables(e.g. useMouseInElement) should be done in separate PRs |
I thought the same, but this PR needs those changes to make the new function work, so I must wait until those separate PRs are merged before opening this PR, otherwise the CI would fail. Sorry about my terrible git skill, is there a decent workaround to do this? |
It would be best to open up the other PRs and just make a note of it in this one that it depends on the other PRs. Once those are merged you can then bring this on up to date with main and then the tests will pass |
Thanks, sounds nice. I will do this later. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There seems to be no other PRs, is it time for it to move forward? |
Description
Add custom
contextMenu
to an Element.this PR depends on 2 changes:
box
sizing #2143includeScrollbar
#2161demo.mov
Additional context
I closed the previous PR because the commit history is too messy.
And of course feel free to correct my English grammar issues in the files~ 🤪
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).