Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: impove test coverage #2185

Merged
merged 9 commits into from
Sep 16, 2022
Merged

test: impove test coverage #2185

merged 9 commits into from
Sep 16, 2022

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Sep 9, 2022

Description

This is a long-term branch. All PRs from this branch intend to increase UT coverage and optimize vueuse source code. I will continuously commit test code to this branch.

All commits in this branch are atomic, feel free to merge PR at any time.@antfu

Updated UT Coverage

api statements branches functions lines
useColorMode 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️
useCached 100% 100% 100% ⬆️ 100%
useFocusWithin 100% 100% ⬆️ 100% 100%
computedWithControl 100% 100% 100% ⬆️ 100%
useStepper 100% ⬆️ 100% ⬆️ 100% 100% ⬆️
useFetch 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Test

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day
Copy link
Member Author

sun0day commented Sep 13, 2022

function useFactoryFetch(url: MaybeComputedRef<string>, ...args: any[]) {
const computedUrl = computed(() => config.baseUrl
? joinPaths(resolveUnref(config.baseUrl), resolveUnref(url))
: resolveUnref(url),
)

const useMyFetch = createFetch({ baseUrl: 'https://example.com', fetchOptions: {...}})

useMyFetch('test') // request https://example.com/test
useMyFetch('https://a.com/test') // request https://example.com/https://a.com/test

Is it better to support sending the custom request to an absolute URL as axios do? @antfu

image

@antfu antfu added the no stale label Sep 14, 2022
@antfu
Copy link
Member

antfu commented Sep 16, 2022

Is it better to support sending the custom request to an absolute URL as axios do?

Nice catch, yes that would be nice! 👍

@antfu antfu changed the title unit test coverage update test: impove test coverage Sep 16, 2022
@antfu
Copy link
Member

antfu commented Sep 16, 2022

Nice work, thank you! Let's merge it for now, and feel free to open more PRs to continue working on other functions.

@antfu antfu enabled auto-merge (squash) September 16, 2022 02:45
@antfu antfu merged commit 02f9f5f into vueuse:main Sep 16, 2022
@sun0day sun0day mentioned this pull request Oct 7, 2022
9 tasks
@sun0day sun0day mentioned this pull request Oct 17, 2022
9 tasks
@sun0day sun0day mentioned this pull request Oct 25, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants