-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: impove test coverage #2185
Conversation
…ctions 100% lines 100%
… functions 100% lines 100%
…nches 100% functions 100% lines 100%
…ns 100% lines 100%
vueuse/packages/core/useFetch/index.ts Lines 231 to 235 in 56ce7e6
const useMyFetch = createFetch({ baseUrl: 'https://example.com', fetchOptions: {...}})
useMyFetch('test') // request https://example.com/test
useMyFetch('https://a.com/test') // request https://example.com/https://a.com/test Is it better to support sending the custom request to an absolute URL as |
Nice catch, yes that would be nice! 👍 |
Nice work, thank you! Let's merge it for now, and feel free to open more PRs to continue working on other functions. |
Description
This is a long-term branch. All PRs from this branch intend to increase UT coverage and optimize vueuse source code. I will continuously commit test code to this branch.
All commits in this branch are atomic, feel free to merge PR at any time.@antfu
Updated UT Coverage
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).