Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(computedWithControl): add vue2 compatibility #2186

Closed
wants to merge 3 commits into from

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Sep 9, 2022

Description

Since a ref in vue2 can't be extensible, but we could return the trigger separately. It's off by default for not breaking previous usage, set the third parameter as true to turn it on.

It's being verbose with the third parameter, maybe we could turn it on by default in the next major version.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vaakian vaakian changed the title fix(ComputedWithControl): add vue2 compatibility fix(computedWithControl): add vue2 compatibility Sep 9, 2022
@antfu antfu added the no stale label Sep 14, 2022
@antfu
Copy link
Member

antfu commented Nov 9, 2022

Thank you but returning an array violates VueUse's convention. For users who absolutely need Vue2, I would suggest implementing it in their own codebase directly. Thanks for your contribution.

@antfu antfu closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants