feat(useWebSocket): redefine url / parameter #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellerza
reviewed
Sep 15, 2022
| ```js | ||
| import { useWebSocket } from '@vueuse/core' | ||
|
|
||
| const ws = useWebSocket('ws://websocketurl?jwt=123', { |
There was a problem hiding this comment.
Very nice! This websocket address becomes completely optional?
There was a problem hiding this comment.
It's rather the fallback as there needs to be an address for immediate and retries
There was a problem hiding this comment.
Ah yes, immediate needs to be false indeed!
kellerza
previously approved these changes
Sep 15, 2022
Co-authored-by: Johann Kellerman <kellerza@gmail.com>
9 tasks
|
Thank you. Close in favor of #2473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some Websocket server (e.g. ditto) expect a dynamic authorization parameter. This pull requests allows adjusting the (parameter of the) Websocket url.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).