Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onClickOutside): call handler if click event is fired by a keypress #2426

merged 2 commits into from Nov 13, 2022


Copy link

@sibbng sibbng commented Nov 10, 2022



  1. Click "Open Modal"
  2. Press Tab, your focus is now on "Toggle Dropdown" button
  3. Press Space. Dropdown opens but Modal is still there, it should be closed since a click event is fired outside the modal.

Try the same thing by clicking "Toggle Dropdown" first. It works as expected. This PR fixes that inconsistency.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants