Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useWindowScroll): use configured window onScroll #2545

merged 1 commit into from Dec 16, 2022


Copy link

@94726 94726 commented Dec 14, 2022


makes useWindowScroll use the given window for the scroll listener.

fixes #2544

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

webfansplz commented Dec 16, 2022

First of all, this PR is fine.But we’ll deprecate this function and recommend users to use useScroll function.

@antfu antfu merged commit 5df0ab6 into vueuse:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

useWindowScroll custom window option not working
3 participants