fix(useActiveElement): ignore if relatedTarget is set #2600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes useFocus doesn't update on blur #2565
fixes useFocusWithin gives incorrect values #2214
replaces feat(useActiveElement): optionally ignore active <body> element #2591
I'm so sorry!
My PR #2540 has actually broken the functionality.
Additional context
The description was correct, but instead of ignoring the listener if there is a
relatedTarget
the code ignored the listener if therelatedTarget
isnull
.There are two other PRs that try to solve this but in a different way:
ignoreBody
which seems not necessary since it increases complexity. On top by merging fix(useActiveElement): ignore blur for relatedTarget #2540 an implicit agreement was already established that the active element shouldn't be<body>
in between if the focus is about to change.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).