Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useActiveElement): ignore if relatedTarget is set #2600



Copy link

@dpschen dpschen commented Dec 30, 2022


I'm so sorry!
My PR #2540 has actually broken the functionality.

Additional context

The description was correct, but instead of ignoring the listener if there is a relatedTarget the code ignored the listener if the relatedTarget is null.

There are two other PRs that try to solve this but in a different way:

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit ae78d8b into vueuse:main Jan 3, 2023
3 of 5 checks passed
@dpschen dpschen deleted the fix/useActiveElement-ignore-if-relatedTarget-set branch February 1, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

useFocus doesn't update on blur useFocusWithin gives incorrect values
2 participants