Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useThrottleFn): check negative timeout #2620

Merged
merged 5 commits into from Feb 18, 2023

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Jan 5, 2023

Description

fixes #2618

Additional context

caused by a BIG negative timeout. Exists in the past versions as well, but only occurs at the first call.

const printHello = () => console.log('hello')
// will not print `hello`
setTimeout(printHello, -1672930567173)

// will print `hello`
setTimeout(printHello, -167293056)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

wheatjs
wheatjs previously approved these changes Jan 7, 2023
@shrpne
Copy link

shrpne commented Jan 13, 2023

@vaakian can you update your PR please?

@antfu antfu merged commit a7238d8 into vueuse:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseThrottleFn does not call function - completely broken
5 participants