feat(useParentElement): new function #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-solanki
changed the title
4 tasks
|
BTW, I am wondering if it's possible to aware that a <div id="container1">
<div id="target"></div>
</div>
<div id="container2">
<!-- move #target here -->
</div>
<script>
const container2 = document.querySelector('#container2')
const target = document.querySelector('#target')
// move #target to #container2
container2.appendChild(target)
</script>I think maybe MutationObserver would work. |
antfu
reviewed
Mar 14, 2023
Comment on lines
15
to
17
| return { | ||
| parentElement, | ||
| } |
There was a problem hiding this comment.
Suggested change
| return { | |
| parentElement, | |
| } | |
| return parentElement |
Do you foresee any other things to return in the future?
antfu
reviewed
Mar 14, 2023
| import { getCurrentInstance, ref } from 'vue-demi' | ||
| import { unrefElement } from '../unrefElement' | ||
|
|
||
| export const useParentElement = (element?: MaybeComputedRef<HTMLElement | SVGElement | null | undefined>) => { |
antfu
previously approved these changes
Mar 28, 2023
antfu
approved these changes
Mar 28, 2023
|
Sorry team, I was busy lately and couldn't update the PR. Thanks, Anthony for the updates 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This function allows getting the parent element of the current element or passed
ref.Additional context
Porting
useParentElementfrom Anu to VueUse as discussed here: #2814What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).