Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fromEvent): torn down properly #3155

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Jun 14, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [?] Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This addresses issues with fromEvent, wherein if the ref is updated to a new HTMLElement or to anything really, the event listeners from the prevent elements are not torn down. This also improves the performance profile of the implementation a bit.

Additional context

The only way I could figure out to test this was manually.

Pair programmed with @JessicaSachs .


🤖 Generated by Copilot at 64ba802

Improved from and fromEvent functions in @vueuse/rxjs package. Fixed a bug with ref elements in fromEvent.

🤖 Generated by Copilot at 64ba802

  • Refactor fromEvent function to avoid memory leaks and update event source when ref changes (link,link)

The old implementation had an issue where it would never clean up previous subscriptions to rxjs fromEvent. It's presumed that most uses of this helper would be for a single element's event.
…LElement

+ Also reimplements the utility to use fewer operators, and therefor create fewer subscriptions. Observed about 50% decrease in scripting time while executed.
@antfu antfu changed the title From event fixes fix(fromEvent): torn down properly Jun 15, 2023
@antfu antfu merged commit fa7ed3a into vueuse:main Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants