fix(fromEvent): torn down properly #3155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
This addresses issues with
fromEvent
, wherein if the ref is updated to a new HTMLElement or to anything really, the event listeners from the prevent elements are not torn down. This also improves the performance profile of the implementation a bit.Additional context
The only way I could figure out to test this was manually.
Pair programmed with @JessicaSachs .
🤖 Generated by Copilot at 64ba802
Improved
from
andfromEvent
functions in@vueuse/rxjs
package. Fixed a bug with ref elements infromEvent
.🤖 Generated by Copilot at 64ba802
fromEvent
function to avoid memory leaks and update event source when ref changes (link,link)