Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFetch): generated payloadType on execute #3251

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

tolking
Copy link
Contributor

@tolking tolking commented Jul 23, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

close #3250

Additional context


🤖 Generated by Copilot at f85bdf3

Improved the handling of different payload types and headers in useFetch and added tests to verify the functionality. Refactored the code to avoid duplication and ensure consistency.

🤖 Generated by Copilot at f85bdf3

  • Move the logic for setting the payload type and the Content-Type header to the main useFetch function, to ensure consistency and avoid duplication (link, link)
  • Modify the condition for setting the payload type to json to exclude FormData instances, since they are handled by fetch without specifying the header (link)
  • Add two test cases to check the behavior of useFetch with different types of payloads (JSON and FormData) and how the Content-Type header is set accordingly (link)
  • Use the ref function from Vue to create reactive values for the payload and the retry function from the test utils to wait for the fetch call to complete and assert the expected header value in the test cases (link)

@tolking tolking changed the title fix(useFetch): should be generated payloadType on execute fix(useFetch): generated payloadType on execute Jul 23, 2023
@antfu antfu added this pull request to the merge queue Jul 30, 2023
Merged via the queue into vueuse:main with commit b7e3d7e Jul 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[useFetch] In some cases, the Content-Type is incorrect
2 participants