Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(use-url-search-params): missing initial url params #340

Merged
merged 4 commits into from
Feb 22, 2021
Merged

fix(use-url-search-params): missing initial url params #340

merged 4 commits into from
Feb 22, 2021

Conversation

lstoeferle
Copy link
Member

Hi @antfu,
I found an issue in the useUrlSearchParams composable:

initial UrlSearchParams are not returned by the composable. Only after you modify the object or trigger a popstate event.

I also added a test for this issue and changed the documentation to use the demo.vue approach.

@antfu antfu enabled auto-merge (squash) February 22, 2021 14:25
@antfu antfu merged commit f8d4f1a into vueuse:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lstoeferle @antfu