Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useFavicon): Add link tag if it doesn't exist #3444

Merged
merged 1 commit into from Oct 7, 2023

Conversation

babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Oct 1, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Unable to verify with unit test
I deleted the link tag on the demo and ran it to confirm that the link tag was added.

⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fix #3439

Additional context


🤖 Generated by Copilot at f8142c7

Fixed a bug and improved compatibility for useFavicon function. The function now creates and sets the appropriate link element for the favicon if it does not exist in the document.

🤖 Generated by Copilot at f8142c7

  • Fix favicon not applying if no link element exists (link)

@antfu antfu changed the title fix(useFavicon): Add link tag if it doesn't exist feat(useFavicon): Add link tag if it doesn't exist Oct 7, 2023
@antfu antfu enabled auto-merge October 7, 2023 06:57
@antfu antfu added this pull request to the merge queue Oct 7, 2023
Merged via the queue into vueuse:main with commit d1fcc57 Oct 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useFavicon don't work
3 participants