-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useScroll): add onError
hook and avoid throws by default, fix #3580
#3605
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
315d692
fix: useScroll bugfix, #3580
steklopod 974c177
fix: On error callback added to `packages/core/useScroll/index.ts`, #…
steklopod 2173b85
Update packages/core/useScroll/index.ts
steklopod cabd9da
Update packages/core/useScroll/index.ts
steklopod 7142d23
Merge branch 'main' into 3580-useScroll_fix
steklopod f60ad6d
Merge branch 'main' into 3580-useScroll_fix
antfu 2becec2
Merge branch 'main' into 3580-useScroll_fix
antfu 801181e
chore: update
antfu 0cd918c
chore: lint
antfu f75c8b1
fix: type fix for `getComputedStyle(el)`, #3580
steklopod f56331f
chore: fix
antfu 31e90d6
chore: lint
antfu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the try cache here. Ideally we should make it safe. If it's an error that not possible to workaround, I'd prefer to expose a
onError
handler to users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 👍🏻
onError
callback was added topackages/core/useScroll/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. But the first thing is how would the error get triggered here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the root of the problem was highlighted by brendomaciel 👇🏻#3605 (comment)