Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useScroll): add
onError
hook and avoid throws by default, fix #3580 #3605fix(useScroll): add
onError
hook and avoid throws by default, fix #3580 #3605Changes from 2 commits
315d692
974c177
2173b85
cabd9da
7142d23
f60ad6d
2becec2
801181e
0cd918c
f75c8b1
f56331f
31e90d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be the root of the problem 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sorry for the lack of explanation.
The problem occurs because, when using
ref
with components, its value is a component instance instead of the component's root element1. Naturally, sincegetComputedStyle
doesn't exist on the instance object, an error is thrown.Luckily, VueUse already have something to handle this, the
unrefElement
2 that I used in the suggestion.Footnotes
https://vuejs.org/guide/essentials/template-refs.html#ref-on-component ↩
https://vueuse.org/core/unrefElement/#unrefelement ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the try cache here. Ideally we should make it safe. If it's an error that not possible to workaround, I'd prefer to expose a
onError
handler to users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 👍🏻
onError
callback was added topackages/core/useScroll/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. But the first thing is how would the error get triggered here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the root of the problem was highlighted by brendomaciel 👇🏻#3605 (comment)