Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMounted): compatible with vue2.7 #3802

Merged
merged 1 commit into from Feb 21, 2024
Merged

fix(useMounted): compatible with vue2.7 #3802

merged 1 commit into from Feb 21, 2024

Conversation

yanbowe
Copy link
Contributor

@yanbowe yanbowe commented Feb 21, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fix #3803

Additional context

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. direction: approved The direction of feature/change is approved by the team. May require some small changes. vue: upstream labels Feb 21, 2024
@antfu antfu removed direction: approved The direction of feature/change is approved by the team. May require some small changes. vue: upstream labels Feb 21, 2024
@Glandos
Copy link
Contributor

Glandos commented Mar 15, 2024

Indeed, the Typescript written in https://github.com/vuejs/vue/blob/bed04a77e575d6c4c1d903f60087dca874f7213e/src/v3/apiLifecycle.ts#L6 results in the following generated code:

function createLifeCycle(hookName) {
    return function (fn, target) {
        if (target === void 0) { target = currentInstance; }
        if (!target) {
            process.env.NODE_ENV !== 'production' &&
                warn("".concat(formatName(hookName), " is called when there is no active component instance to be ") +
                    "associated with. " +
                    "Lifecycle injection APIs can only be used during execution of setup().");
            return;
        }
        return injectHook(target, hookName, fn);
    };
}

Since target is strictly checked against undefined (aka void 0), the modification here doesn't work. #3830 is the way to go, albeit using undefined for better readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useMounted does not work in vue2.7
3 participants