feat(useTransition): support for delayed transitions #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Mar 25, 2021
packages/core/useTransition/index.ts
Outdated
| @@ -172,6 +179,13 @@ export function useTransition( | |||
|
|
|||
| resume() | |||
| onStarted() | |||
| } | |||
|
|
|||
| const timeout = useTimeoutFn(start, delay) | |||
There was a problem hiding this comment.
Should we pass immediate: false here?
There was a problem hiding this comment.
Good catch! Because of the way I wrote my tests, I didn't notice this.
Resolved 345d8c1
antfu
changed the title
antfu
pushed a commit
that referenced
this pull request
May 11, 2021
Closed
antfu
added a commit
that referenced
this pull request
Jun 6, 2021
* feat(useTransition): support for vectors (#376) * refactor(useTransition): cleaning up (#385) * refactor(useWebWorkerFn): Small doc and type improvements (#382) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * feat: pwa reload prompt * chore: update docs * refactor(useWebWorkerFn): Small doc and type improvements (#382) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * chore: update docs * test: simpilfy tests for useTransition * chore: fix tests * feat(useTransition): support for delayed transitions (#386) * feat(useTransition): support for disabled transitions (#436) * feat!: introduce `controls` option * chore: update * chore: update * refactor(useRafFn): remove depreacted APIs * chore: enabled tests for next branch * fix(useFetch)!: allow setting response type before doing request (#454) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * chore: resolve conflicts * feat(useMediaControls): expose source types (#495) * fix(useMediaControls): Removes tracks that have been inserted in html (#493) * chore: release v4.9.3 * fix(usePermission): tolerate error on FireFox * fix(useDevicesList): treat as premssion granted after getUserMedia * chore: release v4.9.4 * chore: fix typo (#502) * feat(useWebSocket): add immediate option (#503) * feat(useAxios): bring API into line with useFetch (#499) * feat(createEventHook): new function (#497) * chore: release v4.10.0 * fix(useMediaControls): Doesn't rewrite default media properties (#500) * feat(useMediaControls): add error event (#509) * feat(useStorage): optimize event handling logic (#505) * feat(useFetch): add afterFetch option, onFetchResponse, and onFetchError (#506) * feat(useWebWoker): return worker (#507) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * fix: Change `onMediaError` to `onSourceError` (#510) * feat(onClickOutside): default to just pointerDown (#508) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> Co-authored-by: sibbng <sibbngheid@gmail.com> * chore: update docs * chore: release v4.11.0 * fix(onClickOutside): duplicate code (#519) Co-authored-by: Nurettin Kaya <sibbngheid@gmail.com> * feat(createEventHook): added interface (#531) * feat(createEventHook): added interface * added types for EventHookOn, EventHookOff, and EventHook trigger * feat(useStorage): allow custom serializer (#528) * feat(useStorage): allow custom serializer * update test * refactor(useMediaControls): Deprecate options that can simply be set as attributes (#514) * useMediaControls: Add `volumechange` event listener * fix: `mute` returned * feat: Deprecate video options: * `poster` * `autoplay` * `preload` * `loop` * `controls` * `playsinline` * `autoPictureInPicture` * fix: Fix deprecated behaviour in demo * fix: Remove deprecated usage from doc * refactor: More polite messages * fix: Remove `console.warn`s * chore: release v4.11.1 * refactor!: remove deprecated apis * chore: add next tag * chore: release v5.0.0-beta.1 * feat: introduce `components` & `directives` (#486) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * docs: re-organize * chore: fix lint * docs: about components * chore: include directives * chore: release v5.0.0-beta.2 * chore: rollback jest * chore: fix docs build * docs: readme for components * docs: add @vueuse/gesture * chore: ship indexes.json * chore: release v5.0.0-beta.3 * feat(typedef): add return typedefs (#543) (#544) * refactor!: change publish strcture and support submodules, close #469 * chore: cleanup stories.tsx * docs: update docs about submodules * chore: fix docs * chore: release v5.0.0-beta.4 * chore: update lock * chore: release v5.0.0-beta.5 * chore: update deps and extend publish memory * refactor: remove `useDeviceLight` * chore: update * chore: fix tests * chore: release v5.0.0-beta.7 * refactor(useWebSocket)!: change immediate default for 5.0.0 (#545) * feat(useIpcRenderer): new add-one & new functions (#547) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> * chore: update deps * chore: release v5.0.0-beta.8 * chore: fix docs build * chore(usePointerSwipe): fix typo (#557) * fix(useAuth): now reqiures the auth instance, close #538 * chore: update deps * docs(biSyncRef): fix console output comment (#555) * docs: removed deprecated value from example (#556) * docs(guidlines): added guidelines (#535) * docs: update guidelines * chore: update guidelines Co-authored-by: Scott Bedard <scottbedard@users.noreply.github.com> Co-authored-by: Fabian <donskelle@googlemail.com> Co-authored-by: Ismail Gjevori <isgjevori@protonmail.com> Co-authored-by: Alex Kozack <cawa-93@users.noreply.github.com> Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: wheat <jacobrclevenger@gmail.com> Co-authored-by: sibbng <sibbngheid@gmail.com> Co-authored-by: JserWang <jserwang@gmail.com> Co-authored-by: Pig Fang <g-plane@hotmail.com> Co-authored-by: ArcherGu <34826812+ArcherGu@users.noreply.github.com> Co-authored-by: Ilya Komichev <hello@ilko.me> Co-authored-by: Daiki Ojima <daiking.ca2@gmail.com> Co-authored-by: Manaus <manaustransez@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick helper option to make delayed and staggered transitions easier. Also, I take back my claim before that
onStartedwas unnecessary. It definitely serves a useful purpose now! 馃槄More info here #364
This also includes a tiny change to
useTimeoutFn, in that now it supports aMaybeRef<number>as the interval.